netdev - Re: question about tulip/winbond-840.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP6odjiCpBxAhWrMLjTQTwnwNsBiFo5ojDpFo+MPpT0Jd8xyNw@mail.gmail.com>
Date:	Thu, 2 Jan 2014 08:53:07 -0800
From:	Grant Grundler <grantgrundler@...il.com>
To:	Julia Lawall <julia.lawall@...6.fr>
Cc:	Grant Grundler <grundler@...isc-linux.org>,
	"open list:TULIP NETWORK DRI..." <netdev@...r.kernel.org>
Subject: Re: question about tulip/winbond-840.c

On Thu, Jan 2, 2014 at 8:16 AM, Julia Lawall <julia.lawall@...6.fr> wrote:
...
> It does set up more things.  But it doesn't do much if the device has not
> been disabled.
> http://lxr.free-electrons.com/source/drivers/pci/pci.c#L1190

Sure...but this driver _should_ disable on suspend. But who knows...my
guess is that if anyone has tried suspending this device, it works
anyway on resume.

> Looking across the entire Linux kernel, I see cases where there are
> enables but no disables, and cases where there are disables and no
> enables.  So I wouldn't really know whether a change is needed.

I think both cases are wrong. I'm pretty sure enable/disable should be
symmetric for both "init_one/remove_one"  and suspend/resume.  I'm not
aware of any reason why they would not be.

cheers,
grant
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html