netdev - Re: [net-next 6/9] ixgbe: Add Live Error Recovery configuration option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1388686513.9947.14.camel@bwh-desktop.uk.level5networks.com>
Date:	Thu, 2 Jan 2014 18:15:13 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
CC:	<davem@...emloft.net>, Mark Rustad <mark.d.rustad@...el.com>,
	<netdev@...r.kernel.org>, <gospo@...hat.com>, <sassmann@...hat.com>
Subject: Re: [net-next 6/9] ixgbe: Add Live Error Recovery configuration
 option

On Thu, 2014-01-02 at 01:33 -0800, Jeff Kirsher wrote:
> From: Mark Rustad <mark.d.rustad@...el.com>
> 
> CONFIG_IXGBE_LER is added to control LER, Live Error Recovery
> support to save a little CPU utilization in environments that
> don't support LER. Thunderbolt environments also benefit from
> having this enabled.
[...]

This is a strange way of explaining it:

'Disabling it does A.  Enabling it also does B.'

There's no 'also' here; users have to trade-off A against B.
The Kconfig help text has the same problem.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html