netdev - Re: [PATCH 5/5] bgmac: add support for Northstar SoC (BCM4707, BCM53018)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACna6rxrOOcb=xbeCytjWALAPOAj-P7Js5Xe7L1ykCimmDa4Sw@mail.gmail.com>
Date:	Thu, 2 Jan 2014 21:40:00 +0100
From:	Rafał Miłecki <zajec5@...il.com>
To:	Hauke Mehrtens <hauke@...ke-m.de>
Cc:	David Miller <davem@...emloft.net>,
	Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH 5/5] bgmac: add support for Northstar SoC (BCM4707, BCM53018)

 > +       if (ci->id == BCMA_CHIP_ID_BCM4707 ||
> +           ci->id == BCMA_CHIP_ID_BCM53018) {

Please add a missing
if (bgmac->phyaddr != BGMAC_PHY_NOREGS)
return;
at the beginning of this 4707/53018 block


> +               bcma_awrite32(core, BCMA_IOCTL,
> +                             bcma_aread32(core, BCMA_IOCTL) | 0x44);

Please use
BGMAC_BCMA_IOCTL_SW_CLKEN | 0x40
(unless you know 0x40, then replace it too).


> +                       bgmac->mac_speed = SPEED_2500;
> +                       bgmac->mac_duplex = DUPLEX_FULL;
> +                       bgmac_mac_speed(bgmac);

Wrong indent above.


> @@ -911,7 +926,8 @@ static void bgmac_chip_reset(struct bgmac *bgmac)
>
>         bcma_core_enable(core, flags);

Look closer. Don't calculate flags and don't call bcma_core_enable for
4707 (but call it for 53018).


> -       if (core->id.rev > 2) {
> +       if (core->id.rev > 2 && ci->id != BCMA_CHIP_ID_BCM4707 &&
> +           ci->id != BCMA_CHIP_ID_BCM53018) {

Could you put 4707 check on the separated line? I'm not pushing however.

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html