netdev - Re: [PATCH 24/31] staging: r8188eu: Additional cleanup of include/odm.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52C5E26A.5000704@lwfinger.net>
Date:	Thu, 02 Jan 2014 16:04:26 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Dan Carpenter <dan.carpenter@...cle.com>
CC:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH 24/31] staging: r8188eu: Additional cleanup of include/odm.h

On 01/02/2014 03:05 AM, Dan Carpenter wrote:
> On Sun, Dec 22, 2013 at 05:36:55PM -0600, Larry Finger wrote:
>> --- a/drivers/staging/rtl8188eu/include/odm_interface.h
>> +++ b/drivers/staging/rtl8188eu/include/odm_interface.h
>> @@ -51,7 +51,7 @@ ODM_REG(DIG,_pDM_Odm)
>>
>>   #define _cat(_name, _ic_type, _func)					\
>>   	(								\
>> -		((_ic_type) & ODM_IC_11N_SERIES) ? _func##_11N(_name) :	\
>> +		(_ic_type) ? _func##_11N(_name) :			\
>>   		_func##_11AC(_name)					\
>>   	)
>
> The original version of this function was more readable...  I think
> _ic_type is either zero or 16?

The original driver has some code that supports many different chips; however, 
the present one only works for RTL8188E.

In the current driver, ODM_RTL8188E is always the only bit in odm_ic_type, thus 
it is always 16. As a result (_ic_type & ODM_IC_11N_SERIES) is always equal to 
_ic_type, which is why I simplified the macro.

If you really prefer the original version of the macro, I will leave it.

Larry

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html