netdev - Re: [PATCH net-next] ipv6: fix the use of pcpu_tstats in ip6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1388634983.12212.85.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 01 Jan 2014 19:56:23 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH net-next] ipv6: fix the use of pcpu_tstats in ip6_tunnel

On Thu, 2014-01-02 at 08:49 +0800, roy.qing.li@...il.com wrote:
> From: Li RongQing <roy.qing.li@...il.com>
> 
> when read/write the 64bit data, the correct lock should be hold. and use the
> BUILD_BUG_ON check to ensure the syncp is last element of struct pcpu_tstats,
> then reduce the copy the syncp when get the stats

No idea of why you added a BUILD_BUG_ON(), this makes no sense.

> 
> Eric Dumazet <edumazet@...gle.com>

Why is my name mentioned in this changelog ?

> Signed-off-by: Li RongQing <roy.qing.li@...il.com>
> ---
>  net/ipv6/ip6_tunnel.c |   25 ++++++++++++++++++-------
>  1 file changed, 18 insertions(+), 7 deletions(-)

Could you find out when the bug was introduced ?

Ideally you should add :

Fixes : 12-digit SHA1 ("patch title")

Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html