netdev - Re: [PATCHv4 net-next 3/8] {pktgen, xfrm} Correct xfrm_state_lock usage in xfrm_stateonly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140102073225.GN31491@secunet.com>
Date:	Thu, 2 Jan 2014 08:32:25 +0100
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Fan Du <fan.du@...driver.com>
Cc:	davem@...emloft.net, hadi@...erus.ca, netdev@...r.kernel.org
Subject: Re: [PATCHv4 net-next 3/8] {pktgen, xfrm} Correct xfrm_state_lock
 usage in xfrm_stateonly_find

On Fri, Dec 20, 2013 at 10:33:29AM +0800, Fan Du wrote:
> ---
>  net/xfrm/xfrm_state.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
> index 68c2f35..f7cb4a3 100644
> --- a/net/xfrm/xfrm_state.c
> +++ b/net/xfrm/xfrm_state.c
> @@ -900,7 +900,7 @@ xfrm_stateonly_find(struct net *net, u32 mark,
>  	unsigned int h;
>  	struct xfrm_state *rx = NULL, *x = NULL;
>  
> -	spin_lock(&xfrm_state_lock);
> +	spin_lock_bh(&xfrm_state_lock);

This does not apply to ipsec-next, xfrm_state_lock is
now namespace aware. Please rebase your patchset to
ipsec-next current.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html