netdev - Re: [Patch] netxen_nic: Bugfix for wrong RUNNING status of NX3031 NICs with no link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OFEE191896.FD28476A-ON48257C54.003205EE-48257C54.0032F33D@zte.com.cn>
Date:	Thu, 2 Jan 2014 17:16:17 +0800
From:	jiang.biao2@....com.cn
To:	David Miller <davem@...emloft.net>
Cc:	li.fengmao@....com.cn, manish.chopra@...gic.com,
	netdev@...r.kernel.org, rajesh.borundia@...gic.com,
	sony.chacko@...gic.com
Subject:  Re: [Patch] netxen_nic: Bugfix for wrong RUNNING status of NX3031 NICs
 with no link

> You cannot do this, because at the very exact moment you call
> register_netdevice() the device can be brought up and once the
> device is up the link can be brought up.

> Therefore if you invoke netif_carrier_off() right after
> register_netdevice(), it can cancel out a legitimate
> netif_carrier_on() call.

register_netdevice() should be call in probe(), at that time, is
it impossible to bring up device because the driver loading has
not finished?

Even that, the netif_carrier_off() will be called before
netif_carrier_on(), and that will not be a problem.

Besides, the other net drivers(e.g igb, e1000, e1000e) I saw all
call netif_carrier_off() after register_netdev(). There is no such
problems in these drivers.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html