netdev - Re: [PATCH] sh_eth: coding style fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1388713347.2259.86.camel@joe-AO722>
Date:	Thu, 02 Jan 2014 17:42:27 -0800
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	sergei.shtylyov@...entembedded.com, netdev@...r.kernel.org,
	linux-sh@...r.kernel.org
Subject: Re: [PATCH] sh_eth: coding style fixes

On Thu, 2014-01-02 at 19:34 -0500, David Miller wrote:
> From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> Date: Tue, 31 Dec 2013 03:25:21 +0300
> 
> > @@ -1952,8 +1949,8 @@ static void sh_eth_tx_timeout(struct net
> >  	netif_stop_queue(ndev);
> >  
> >  	if (netif_msg_timer(mdp))
> > -		dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x,"
> > -	       " resetting...\n", ndev->name, (int)sh_eth_read(ndev, EESR));
> > +		dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x, resetting...\n"
> > +			ndev->name, (int)sh_eth_read(ndev, EESR));
> >  
> >  	/* tx_errors count up */
> >  	ndev->stats.tx_errors++;
> 
> You did not build test this.
> 
> drivers/net/ethernet/renesas/sh_eth.c: In function ‘sh_eth_tx_timeout’:
> drivers/net/ethernet/renesas/sh_eth.c:1953:4: error: expected ‘)’ before ‘ndev’

Also, this would likely be better as:

	netif_err(mdp, timer, ndev, "transmit timed out, status %#08lx, resetting...\n",
		  sh_eth_read(ndev, EESR));



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html