netdev - Re: [PATCH] sctp: Add process name and pid to deprecation warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1388708317.22017.25.camel@deadeye.wl.decadent.org.uk>
Date:	Fri, 3 Jan 2014 00:18:37 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Neil Horman <nhorman@...driver.com>
CC:	<linux-sctp@...r.kernel.org>, Vlad Yasevich <vyasevich@...il.com>,
	"David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] sctp: Add process name and pid to deprecation warnings

On Thu, 2014-01-02 at 15:30 -0500, Neil Horman wrote:
> On Thu, Jan 02, 2014 at 07:52:30PM +0000, Ben Hutchings wrote:
> > On Thu, 2014-01-02 at 12:54 -0500, Neil Horman wrote:
> > > Recently I updated the sctp socket option deprecation warnings to be both a bit
> > > more clear and ratelimited to prevent user processes from spamming the log file.
> > > Ben Hutchings suggested that I add the process name and pid to these warnings so
> > > that users can tell who is responsible for using the deprecated apis.  This
> > > patch accomplishes that.
> > [...]
> > 
> > I grepped for existing deprecation warnings that log the command and/or
> > PID.  The warnings are not consistent, but where the include both comand
> > and PID it's generally in the format "%s (%d)", comm, pid.  So please
> > could you follow that format?
> > 
> Thats not really true, Subsystems vary widely in how they present process
> name/pid warnings.  In fact, the first example you give below that uses both
> process and pid, the format is <pid> (<name>)
> 
> There are alot that use <name> (<pid>), I argee, but theres quite alot of others
> as well (the lockdep subssytem uses %s/%d, and several of the arm trap handlers
> actually use Process <name> (pid: <pid>).

Ah, I was just looking specifically at deprecation warnings.  I can see
that broader consistency is also worthwhile.

> I don't have any issue with changing
> it, but I'm not sure what the advantage is if theres not going to be consistent
> use throughout the kernel.

Well I thought you were trying to improve that, starting with that
DEPRECATED macro.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html