netdev - Re: [PATCH v2 net] ipv4: fix tunneled VM traffic over hw VXLAN/GRE GSO NIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Jan 2014 08:44:36 +0200
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	Wei-Chun Chao <weichunc@...mgrid.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Alexei Starovoitov <ast@...mgrid.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Joseph Gasparakis <joseph.gasparakis@...el.com>
Subject: Re: [PATCH v2 net] ipv4: fix tunneled VM traffic over hw VXLAN/GRE
 GSO NIC

On Fri, Jan 3, 2014 at 2:07 AM, David Miller <davem@...emloft.net> wrote:
> From: Wei-Chun Chao <weichunc@...mgrid.com>
> Date: Thu, 26 Dec 2013 13:10:22 -0800
>
>> VM to VM GSO traffic is broken if it goes through VXLAN or GRE
>> tunnel and the physical NIC on the host supports hardware VXLAN/GRE
>> GSO offload (e.g. bnx2x and next-gen mlx4).
>>
>> Two issues -
>> (VXLAN) VM traffic has SKB_GSO_DODGY and SKB_GSO_UDP_TUNNEL with
>> SKB_GSO_TCP/UDP set depending on the inner protocol. GSO header
>> integrity check fails in udp4_ufo_fragment if inner protocol is
>> TCP. Also gso_segs is calculated incorrectly using skb->len that
>> includes tunnel header. Fix: robust check should only be applied
>> to the inner packet.
>>
>> (VXLAN & GRE) Once GSO header integrity check passes, NULL segs
>> is returned and the original skb is sent to hardware. However the
>> tunnel header is already pulled. Fix: tunnel header needs to be
>> restored so that hardware can perform GSO properly on the original
>> packet.
>>
>> Signed-off-by: Wei-Chun Chao <weichunc@...mgrid.com>

> Applied, thanks.

Hi Dave, as I wrote you earlier, could you also add it to your -stable queue?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html