netdev - Re: [PATCH v2] sh_eth: coding style fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Jan 2014 13:04:33 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Linux-sh list <linux-sh@...r.kernel.org>
Subject: Re: [PATCH v2] sh_eth: coding style fixes

On Fri, Jan 3, 2014 at 1:52 PM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> @@ -2739,7 +2734,7 @@ static int sh_eth_drv_probe(struct platf
>
>         /* print device information */
>         pr_info("Base address at 0x%x, %pM, IRQ %d.\n",
> -              (u32)ndev->base_addr, ndev->dev_addr, ndev->irq);
> +               (u32)ndev->base_addr, ndev->dev_addr, ndev->irq);

Hint for the next patch: use 0x%lx and kill the cast.

Thx! ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html