netdev - Re: [PATCH] sh_eth: coding style fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1388759339.14334.10.camel@joe-AO722>
Date:	Fri, 03 Jan 2014 06:28:59 -0800
From:	Joe Perches <joe@...ches.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-sh@...r.kernel.org
Subject: Re: [PATCH] sh_eth: coding style fixes

On Fri, 2014-01-03 at 13:52 +0400, Sergei Shtylyov wrote:
> On 03-01-2014 5:42, Joe Perches wrote:
> >>> @@ -1952,8 +1949,8 @@ static void sh_eth_tx_timeout(struct net
> >>>   	netif_stop_queue(ndev);
> >>>
> >>>   	if (netif_msg_timer(mdp))
> >>> -		dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x,"
> >>> -	       " resetting...\n", ndev->name, (int)sh_eth_read(ndev, EESR));
> >>> +		dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x, resetting...\n"
> >>> +			ndev->name, (int)sh_eth_read(ndev, EESR));
> >>>
> >>>   	/* tx_errors count up */
> >>>   	ndev->stats.tx_errors++;
> 
> >> You did not build test this.
> 
> >> drivers/net/ethernet/renesas/sh_eth.c: In function ‘sh_eth_tx_timeout’:
> >> drivers/net/ethernet/renesas/sh_eth.c:1953:4: error: expected ‘)’ before ‘ndev’
> 
> > Also, this would likely be better as:
> >
> > 	netif_err(mdp, timer, ndev, "transmit timed out, status %#08lx, resetting...\n",
> > 		  sh_eth_read(ndev, EESR));
> 
>  If checkpoint.pl did point this out, I would have fixed it.

That's not really possible to do via checkpatch.
checkpatch is neither a compiler nor a programmer.

There are _many_ patterns that a person (or maybe
spatch) might spot that checkpatch could not.

checkpatch is a brainless scanner and please use
yours over any advice given by checkpatch.

> Since it doesn't, it's probably material of another patch.

All of the dev_<level> uses in this file/module
should be inspected and possibly converted to
netdev_<level> or netif_<level>.  This could change
and improve the output message logging.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html