netdev - Fwd: spin_unlock is missed in function (netpoll_send_skb_on_dev) in file (linux-3.12/net/core/netpoll.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFZT-jLEyU2taPCypVPoV=U8GSVKbqeAB5U+8VtWLnLOKjjZEg@mail.gmail.com>
Date:	Fri, 3 Jan 2014 09:38:15 -0600
From:	Ahmed Tamrawi <ahmedtamrawi@...il.com>
To:	netdev@...r.kernel.org
Subject: Fwd: spin_unlock is missed in function (netpoll_send_skb_on_dev) in
 file (linux-3.12/net/core/netpoll.c)

Hi there!

Bug Report Filed: https://bugzilla.kernel.org/show_bug.cgi?id=68011
Linux Version [3.12]
Configuration: Default configuration for x86

In function (netpoll_send_skb_on_dev) in file (linux-3.12/net/core/netpoll.c):

The structure (txq->_xmit_lock) gets successfully locked at line (383)
by (__netif_tx_trylock(txq)) and unlocked by (__netif_tx_unlock(txq))
at line (398).

The problem occurs when the loop breaks at line (390) and the
structure (txq->_xmit_lock) still locked. In that case, the structure
(txq->_xmit_lock) never gets unlocked.

A possible solution is to call (__netif_tx_unlock(txq)) before the
break at line (390).

Attached is a highlighted source code for the function.

Thanks,
Ahmed

Download attachment "bug_netpoll_send_skb_on_dev.png" of type "image/png" (880311 bytes)