netdev - Re: [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140104135249.7930977c@nehalam.linuxnetplumber.net>
Date:	Sat, 4 Jan 2014 13:52:49 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Jerry Chu <hkchu@...gle.com>
Cc:	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack

On Sat, 4 Jan 2014 13:20:28 +0800
Jerry Chu <hkchu@...gle.com> wrote:

> On Sat, Jan 4, 2014 at 9:51 AM, David Miller <davem@...emloft.net> wrote:
> > From: "H.K. Jerry Chu" <hkchu@...gle.com>
> > Date: Fri,  3 Jan 2014 05:46:53 -0800
> >
> >> +     if (skb->ip_summed == CHECKSUM_COMPLETE)
> >> +             NAPI_GRO_CB(skb)->csum = csum_sub(NAPI_GRO_CB(skb)->csum,
> >> +                     csum_partial(start, len, 0));
> >
> > The csum_partial() call as argument needs to line up to exactly the
> > first column after the openning parenthesis of the csum_sub()
> > invocation.
> >
> > You must use the appropriate number of TAB then SPACE characters
> > necessary to achieve this.
> >
> > If you indent only using TABS then likely you are doing it wrong :)
> 
> Yes I know but sometimes trying to line up arguments either causes > 80
> column long line, or many shorter but highly indented fragmented lines
> following.
> 
> I've fixed the above case and it worked (stopped at 79th column).
> 
> Jerry

80 columns is recommendation not an absolute requirement.
Also, when things get too long, it often means it could be
made clearer by having a helper function or a temporary variable.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html