netdev - Re: [PATCH net-next 1/2] net: Pre-step for supporting GRO on vxlan traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140103.193415.802802822047682766.davem@davemloft.net>
Date:	Fri, 03 Jan 2014 19:34:15 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	ogerlitz@...lanox.com
Cc:	hkchu@...gle.com, edumazet@...gle.com, herbert@...dor.apana.org.au,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: Pre-step for supporting GRO on vxlan
 traffic

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Thu,  2 Jan 2014 15:27:55 +0200

> @@ -1125,8 +1119,8 @@ static void vxlan_rcv(struct vxlan_sock *vs,
>  	 * leave the CHECKSUM_UNNECESSARY, the device checksummed it
>  	 * for us. Otherwise force the upper layers to verify it.
>  	 */
> -	if (skb->ip_summed != CHECKSUM_UNNECESSARY || !skb->encapsulation ||
> -	    !(vxlan->dev->features & NETIF_F_RXCSUM))
> +	if ((skb->ip_summed != CHECKSUM_UNNECESSARY && skb->ip_summed != CHECKSUM_PARTIAL)
> +	    || !skb->encapsulation || !(vxlan->dev->features & NETIF_F_RXCSUM))

Never start conditional continuation lines with the conditional operator.

Operators in a chain always _end_ a line, never begin them.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html