netdev - Re: [PATCH net-next] r8152: fix the wrong return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140103.203759.2168117129392277198.davem@davemloft.net>
Date:	Fri, 03 Jan 2014 20:37:59 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hayeswang@...ltek.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: [PATCH net-next] r8152: fix the wrong return value

From: Hayes Wang <hayeswang@...ltek.com>
Date: Fri, 3 Jan 2014 11:21:56 +0800

> The return value should be the boolean value, not the error code.
> 
> Signed-off-by: Hayes Wang <hayeswang@...ltek.com>
> Spotted-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied, but I agree with others that it's more canonical to have the
function return either an error code, or zero for success, rather than
a boolean.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html