netdev - Re: [net-next v2 08/11] ixgbe: Add Live Error Recovery configuration option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140103.204321.1052262695919537222.davem@davemloft.net>
Date:	Fri, 03 Jan 2014 20:43:21 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	mark.d.rustad@...el.com, netdev@...r.kernel.org, gospo@...hat.com,
	sassmann@...hat.com, bhutchings@...arflare.com
Subject: Re: [net-next v2 08/11] ixgbe: Add Live Error Recovery
 configuration option

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu,  2 Jan 2014 21:18:27 -0800

> From: Mark Rustad <mark.d.rustad@...el.com>
> 
> CONFIG_IXGBE_LER is added to control LER, Live Error Recovery,
> support. This avoids possible crashes in the driver when a device
> is suddenly removed, which is possible in Thunderbolt and other
> environments. Turning this off will save a little CPU utilization.
> 
> Signed-off-by: Mark Rustad <mark.d.rustad@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Compared to the cost of the MMIO register accesses themselves,
the cost of these checks will be negligible.

I also can't think of any distribution which would not enable
this option, so it's basically pointless.

Please remove it and just enable this new code unconditionally.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html