netdev - Re: [Patch net] cls_cgroup: fix memory leak in cls_cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140103.210209.901517258686201934.davem@davemloft.net>
Date:	Fri, 03 Jan 2014 21:02:09 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	netdev@...r.kernel.org, tgraf@...g.ch, jhs@...atatu.com
Subject: Re: [Patch net] cls_cgroup: fix memory leak in cls_cgroup_change()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Fri,  3 Jan 2014 11:13:19 -0800

> Fix it by moving allocation to ->init().
> 
> Cc: Thomas Graf <tgraf@...g.ch>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

I don't understand how the memory leak can happen, please explain
it in your commit message.

Also:

>  {
> +	struct cls_cgroup_head *head;
> +	head = kzalloc(sizeof(*head), GFP_KERNEL);

Please add an empty line between local variable declarations
and code.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html