netdev - Re: [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1388808010.12212.152.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 03 Jan 2014 20:00:10 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	"H.K. Jerry Chu" <hkchu@...gle.com>
Cc:	edumazet@...gle.com, herbert@...dor.apana.org.au,
	ogerlitz@...lanox.com, davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack

On Fri, 2014-01-03 at 05:46 -0800, H.K. Jerry Chu wrote:

> +struct packet_offload *gro_find_receive_by_type(__be16 type)
> +{
> +	struct list_head *offload_head = &offload_base;
> +	struct packet_offload *ptype;

missing newline

> +	list_for_each_entry_rcu(ptype, offload_head, list) {
> +		if (ptype->type != type || !ptype->callbacks.gro_receive)
> +			continue;
> +		return ptype;
> +	}
> +	return NULL;
> +}
> +EXPORT_SYMBOL(gro_find_receive_by_type);
> +
> +struct packet_offload *gro_find_complete_by_type(__be16 type)
> +{
> +	struct list_head *offload_head = &offload_base;
> +	struct packet_offload *ptype;

missing newline

> +	list_for_each_entry_rcu(ptype, offload_head, list) {
> +		if (ptype->type != type || !ptype->callbacks.gro_complete)
> +			continue;
> +		return ptype;
> +	}
> +	return NULL;
> +}
> +EXPORT_SYMBOL(gro_find_complete_by_type);
>  

I do not think there is any reason to export these two helpers.

GRO is static to the kernel.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html