netdev - Re: [net PATCH] netfilter: only warn once on wrong seqadj usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140104131648.GA18176@macbook.localnet>
Date:	Sat, 4 Jan 2014 13:16:48 +0000
From:	Patrick McHardy <kaber@...sh.net>
To:	Jesper Dangaard Brouer <brouer@...hat.com>
Cc:	Pablo Neira Ayuso <pablo@...filter.org>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org, Florian Westphal <fw@...len.de>,
	Daniel Borkmann <dborkman@...hat.com>,
	Flavio Leitner <fbl@...hat.com>
Subject: Re: [net PATCH] netfilter: only warn once on wrong seqadj usage

On Sat, Jan 04, 2014 at 02:10:43PM +0100, Jesper Dangaard Brouer wrote:
> Avoid potentially spamming the kernel log with WARN splash messages
> when catching wrong usage of seqadj, by simply using WARN_ONCE.
> 
> This is a followup to commit db12cf274353 (netfilter: WARN about
> wrong usage of sequence number adjustments)
> 
> Suggested-by: Flavio Leitner <fbl@...hat.com>
> Suggested-by: Daniel Borkmann <dborkman@...hat.com>
> Suggested-by: Florian Westphal <fw@...len.de>
> Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
> ---
> Nitpick found by internal RedHat review process ;-)
> 
>  net/netfilter/nf_conntrack_seqadj.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/netfilter/nf_conntrack_seqadj.c b/net/netfilter/nf_conntrack_seqadj.c
> index b2d38da..f6e2ae9 100644
> --- a/net/netfilter/nf_conntrack_seqadj.c
> +++ b/net/netfilter/nf_conntrack_seqadj.c
> @@ -37,7 +37,7 @@ int nf_ct_seqadj_set(struct nf_conn *ct, enum ip_conntrack_info ctinfo,
>  		return 0;
>  
>  	if (unlikely(!seqadj)) {
> -		WARN(1, "Wrong seqadj usage, missing nfct_seqadj_ext_add()\n");
> +		WARN_ONCE(1, "Missing nfct_seqadj_ext_add() setup call\n");
>  		return 0;

I missed the patch that added the WARN. Since when do we add runtime checks
for API misuse instead of simply letting it crash?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html