netdev - Re: [net-next v5 04/17] i40e: Populate and check pci bus speed and width

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1388898758.2987.1.camel@jtkirshe-mobl>
Date:	Sat, 04 Jan 2014 21:12:38 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	David Miller <davem@...emloft.net>, jesse.brandeburg@...el.com
Cc:	bhelgaas@...gle.com, catherine.sullivan@...el.com,
	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com,
	jesse.brandeburg@...el.com, jacob.e.keller@...el.com
Subject: Re: [net-next v5 04/17] i40e: Populate and check pci bus speed and
 width

On Sat, 2014-01-04 at 19:49 -0500, David Miller wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> Date: Sat, 4 Jan 2014 14:04:30 -0700
> 
> > I don't see anything device-specific here.  This all looks to be
> > generic per the PCIe spec, without anything specific to the i40e.  In
> > fact, this new code looks almost identical to what Jacob added to
> > ixgbe with e027d1aec4bb, except that Jacob's code checks the whole
> > path up to the root, not just the single link leading to the device.
> > 
> > Since you're doing basically the same thing, it'd be nice if the code
> > looked basically the same.
> 
> Agreed.
> 
> I'm going to pull from Jeff's tree meanwhile and ask that this consolidation
> happens as follow-up changes.
> 
> Thanks.

Agreed, I will work with Jesse to make sure those changes get into the
driver in a follow-on patch.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)