netdev - Re: [PATCH V1 net-next 2/2] net: Add UDP GRO support for vxlan traffic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZOPZKfxws+S3ZtTqKQ_yXYhoV=UTOXscM+rVB24UA2d1Fopg@mail.gmail.com>
Date:	Mon, 6 Jan 2014 20:13:45 +0200
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Tom Herbert <therbert@...gle.com>
Cc:	Or Gerlitz <ogerlitz@...lanox.com>, Jerry Chu <hkchu@...gle.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Linux Netdev List <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Yan Burman <yanb@...lanox.com>,
	Shlomo Pongratz <shlomop@...lanox.com>
Subject: Re: [PATCH V1 net-next 2/2] net: Add UDP GRO support for vxlan traffic

On Mon, Jan 6, 2014 at 6:50 PM, Tom Herbert <therbert@...gle.com> wrote:
> I think this would be a good start. We can further optimize the encap
> path later on.

good, did you had the chance to look on the 2nd problem I was facing,
e.g how to prevent gro-ing encapsulated VM (this issue will not happen
for non-virtualization schemes, I think) udp packets which happen to
carry a destination port which belongs to an encapsulation protocol?
as I wrote earlier here, I was thinking to add some field to struct
napi_gro_cb which will be zeroed when the gro stacks starts to work on
the skb and set once we pass udp_gro_receive, such that if we arrive
again to udp_gro_recieve and this field is set, which means the
encapsulated
packet is udp one, we flush.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html