netdev - Re: [PATCH net-next] tcp: out_of_order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140106.163524.1758210592972482694.davem@davemloft.net>
Date:	Mon, 06 Jan 2014 16:35:24 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] tcp: out_of_order_queue do not use its lock

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 06 Jan 2014 09:36:12 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> TCP out_of_order_queue lock is not used, as queue manipulation
> happens with socket lock held and we therefore use the lockless
> skb queue routines (as __skb_queue_head())
> 
> We can use __skb_queue_head_init() instead of skb_queue_head_init()
> to make this more consistent.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.

We should probably at some point try to make an sk_buff_head_lite
that only has the two pointers, so that we could shrink various
structures which have queues which we use like this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html