netdev - Re: [PATCH] hso: fix handling of modem port SERIAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140106.163926.1801604023600319341.davem@davemloft.net>
Date:	Mon, 06 Jan 2014 16:39:26 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	dcbw@...hat.com
Cc:	hns@...delico.com, j.dumon@...ion.com, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	marek.belisko@...il.com, e.verdonck@...ion.com
Subject: Re: [PATCH] hso: fix handling of modem port SERIAL_STATE
 notifications

From: Dan Williams <dcbw@...hat.com>
Date: Mon, 06 Jan 2014 15:39:40 -0600

> If the driver ever gets to that callback for any !Modem port, something
> is horribly wrong, which the BUG_ON() was attempting to make explicit.
> The driver only enables that callback for the Modem port, so yeah, it's
> somewhat defensive.  I'm happy to send a fixup if you like?

You don't have to if you think the BUG_ON() is warranted.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html