netdev - Re: [PATCH net-next v4] IPv6: use anycast addresses as source addresses in echo reply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1389004901.29746.YahooMailBasic@web125506.mail.ne1.yahoo.com>
Date:	Mon, 6 Jan 2014 02:41:41 -0800 (PST)
From:	François-Xavier Le Bail <fx.lebail@...oo.com>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	James Morris <jmorris@...ei.org>,
	Hideaki Yoshifuji <yoshfuji@...ux-ipv6.org>,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH net-next v4] IPv6: use anycast addresses as source addresses in echo reply

On Sun, 1/5/14, Hannes Frederic Sowa <hannes@...essinduktion.org> wrote:

> On Fri, Jan 03, 2014 at 05:43:31PM +0100, Francois-Xavier Le Bail wrote:
> > diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
> > index 5d42009..65c8619 100644
> > --- a/net/ipv6/icmp.c
> > +++ b/net/ipv6/icmp.c
> > @@ -556,7 +556,9 @@ static void icmpv6_echo_reply(struct sk_buff *skb)
> >  
> >  	saddr = &ipv6_hdr(skb)->daddr;
> >  
> > -	if (!ipv6_unicast_destination(skb))
> > +	if (!ipv6_unicast_destination(skb) &&
> > +	    !(net->ipv6.anycast_src_echo_reply &&
> > +	      ipv6_chk_acast_addr(net, NULL, saddr)))
> >  		saddr = NULL;

> I am not sure why you left out the device at ipv6_chk_acast_addr?

> IMHO this logic is a bit more complex, we can pass NULL for ipv6 addresses of
> scope global but need to check the interface for scope link.

> It is already possible via setsockopt JOIN_ANYCAST that an ll address is
> anycast on another interface which may not be checked here.

In this case, there are neighbor solicitations "who has LL anycast" with no reply, so no echo request is sent.

Do you find some problem testing my patch ?

BR
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html