netdev - Re: [net-next 01/15] i40e: Expose AQ debugfs hooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140107.153458.421617056579109012.davem@davemloft.net>
Date:	Tue, 07 Jan 2014 15:34:58 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	anjali.singhai@...el.com, netdev@...r.kernel.org, gospo@...hat.com,
	sassmann@...hat.com, jesse.brandeburg@...el.com
Subject: Re: [net-next 01/15] i40e: Expose AQ debugfs hooks

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Tue,  7 Jan 2014 01:32:15 -0800

> @@ -1523,6 +1523,116 @@ static ssize_t i40e_dbg_command_write(struct file *filp,
>  		} else {
>  			dev_info(&pf->pdev->dev, "clear_stats vsi [seid] or clear_stats pf\n");
>  		}
> +	} else if (strncmp(cmd_buf, "send aq_cmd", 11) == 0) {
> +		struct i40e_aq_desc *desc;
> +		i40e_status ret;
> +		desc = kzalloc(sizeof(struct i40e_aq_desc), GFP_KERNEL);
> +		if (!desc)
> +			goto command_write_done;

Please add an empty line between local variable declarations and code.

> +	} else if (strncmp(cmd_buf, "send indirect aq_cmd", 20) == 0) {
> +		struct i40e_aq_desc *desc;
> +		i40e_status ret;
> +		u16 buffer_len;
> +		u8 *buff;
> +		desc = kzalloc(sizeof(struct i40e_aq_desc), GFP_KERNEL);
> +		if (!desc)
> +			goto command_write_done;

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html