netdev - Re: [Patch net] cls_cgroup: fix memory leak in cls_cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140107211935.GA31788@casper.infradead.org>
Date:	Tue, 7 Jan 2014 21:19:35 +0000
From:	Thomas Graf <tgraf@...g.ch>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [Patch net] cls_cgroup: fix memory leak in cls_cgroup_change()

On 01/06/14 at 03:23pm, Cong Wang wrote:
> On Fri, Jan 3, 2014 at 6:02 PM, David Miller <davem@...emloft.net> wrote:
> > From: Cong Wang <xiyou.wangcong@...il.com>
> > Date: Fri,  3 Jan 2014 11:13:19 -0800
> >
> >> Fix it by moving allocation to ->init().
> >>
> >> Cc: Thomas Graf <tgraf@...g.ch>
> >> Cc: David S. Miller <davem@...emloft.net>
> >> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> >> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>
> >
> > I don't understand how the memory leak can happen, please explain
> > it in your commit message.
> >
> 
> The leak happens when ->change() fails after the allocation
> inside  cls_cgroup_change(), its caller only does cleanup
> when itself creates one. So, the callee should do cleanup
> on error path by itself. But I may miss something.
> 
> Since it is not urgent at all, I will explain this in changelog
> and resend it for net-next.

I have no problem with the intent of the change but I want to
note that the behavior was introduced intentionally to be in
line with behaviour of other classifiers that use chaining.

It's not a leak, the reference is kept and freed when the
chain itself is deleted.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html