netdev - Re: [PATCH net-next] xen-netback: stop vif thread spinning if frontend is unresponsive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140107.162956.1062166230525232035.davem@davemloft.net>
Date:	Tue, 07 Jan 2014 16:29:56 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	paul.durrant@...rix.com
Cc:	netdev@...r.kernel.org, xen-devel@...ts.xen.org,
	wei.liu2@...rix.com, ian.campbell@...rix.com,
	david.vrabel@...rix.com
Subject: Re: [PATCH net-next] xen-netback: stop vif thread spinning if
 frontend is unresponsive

From: Paul Durrant <paul.durrant@...rix.com>
Date: Tue, 7 Jan 2014 16:25:29 +0000

> @@ -477,6 +477,7 @@ static void xenvif_rx_action(struct xenvif *vif)
>  	unsigned long offset;
>  	struct skb_cb_overlay *sco;
>  	int need_to_notify = 0;
> +	int ring_full = 0;

Please use bool, false, and true.

>  
> -	if (!npo.copy_prod)
> +	if (!npo.copy_prod) {
> +		if (ring_full)
> +			vif->rx_queue_stopped = true;
>  		goto done;
> +	}
> +
> +	vif->rx_queue_stopped = false;

And then you can code this as:

	vif->rx_queue_stopped = (!npo.copy_prod && ring_full);
	if (!npo.copy_prod)
		goto done;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html