netdev - Re: [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPshTCj+jXjvKCRdBPZYdxPQzTXqKUdF7x2DJE-fBjECVZfH6A@mail.gmail.com>
Date:	Tue, 7 Jan 2014 14:55:34 -0800
From:	Jerry Chu <hkchu@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	Eric Dumazet <edumazet@...gle.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net-gre-gro: Add GRE support to the GRO stack

On Tue, Jan 7, 2014 at 1:22 PM, David Miller <davem@...emloft.net> wrote:
> From: "H.K. Jerry Chu" <hkchu@...gle.com>
> Date: Tue,  7 Jan 2014 10:23:19 -0800
>
>> From: Jerry Chu <hkchu@...gle.com>
>>
>> This patch built on top of Commit 299603e8370a93dd5d8e8d800f0dff1ce2c53d36
>> ("net-gro: Prepare GRO stack for the upcoming tunneling support") to add
>> the support of the standard GRE (RFC1701/RFC2784/RFC2890) to the GRO
>> stack. It also serves as an example for supporting other encapsulation
>> protocols in the GRO stack in the future.
>  ...
>> Signed-off-by: H.K. Jerry Chu <hkchu@...gle.com>
>> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
>
> Applied, thanks.
>
> We really need to talk about what we want to happen with these GRO
> offloads when GRE is not configured into the kernel.
>
> Right now, the GRO offloads simply won't happen.
>

I hope I've understood this correctly but with Eric's recent patch
"gre_offload: statically build GRE offloading support", gre_offload.o
is always present in the kernel regardless of the GRE configuration
option. And gre_offload.o is all that's needed for GRE-GRO to happen.

Jerry
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html