netdev - Re: [PATCH net] vti: get rid of nf mark rule in prerouting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140106205932.29553fd2@nehalam.linuxnetplumber.net>
Date:	Mon, 6 Jan 2014 20:59:32 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	David Miller <davem@...emloft.net>
Cc:	christophe.gouault@...nd.com, netdev@...r.kernel.org,
	amwang@...hat.com, saurabh@...tta.com
Subject: Re: [PATCH net] vti: get rid of nf mark rule in prerouting

On Fri, 11 Oct 2013 14:53:04 -0400 (EDT)
David Miller <davem@...emloft.net> wrote:

> From: Christophe Gouault <christophe.gouault@...nd.com>
> Date: Tue,  8 Oct 2013 17:21:22 +0200
> 
> > This patch fixes and improves the use of vti interfaces (while
> > lightly changing the way of configuring them).
>  ...
> > Signed-off-by: Christophe Gouault <christophe.gouault@...nd.com>
> > ---
> > This is is both a fix and enhancement patch. However, there are 2 ways
> > of fixing the inbound processing bug:
> > - either keep the current configuration model (ikey + netfilter rule)
> >   and change the tunnel lookup method. This patch would then be reverted
> >   by the enhancement (this sounds counterproductive).
> > - or directly change the configuration model (okey, no netfilter rule) and keep
> >   the current tunnel lookup method.
> 
> Ok, applied and queued up for -stable, thanks.

I hate to reply to old threads, but this keeps context.

We have discovered a problem with this patch, it breaks the earlier use of VTI
because it loses the mark applied through iptables. It was not a "light change"
to the way to configure them and should have gotten more review and was not
appropriate for -stable.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html