netdev - RE: [PATCH 5/6] [v4] phylib: Support attaching to generic 10g driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <242e28ff23a8472a8e13d2f32c764374@BN1PR03MB069.namprd03.prod.outlook.com>
Date:	Tue, 7 Jan 2014 07:04:35 +0000
From:	Shaohui Xie <Shaohui.Xie@...escale.com>
To:	David Miller <davem@...emloft.net>,
	"shh.xie@...il.com" <shh.xie@...il.com>
CC:	"jg1.han@...sung.com" <jg1.han@...sung.com>,
	"mugunthanvnm@...com" <mugunthanvnm@...com>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"afleming@...il.com" <afleming@...il.com>
Subject: RE: [PATCH 5/6] [v4] phylib: Support attaching to generic 10g driver

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Tuesday, January 07, 2014 1:56 PM
> To: shh.xie@...il.com
> Cc: jg1.han@...sung.com; mugunthanvnm@...com; f.fainelli@...il.com;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Xie Shaohui-B21989;
> afleming@...il.com
> Subject: Re: [PATCH 5/6] [v4] phylib: Support attaching to generic 10g
> driver
> 
> From: <shh.xie@...il.com>
> Date: Tue, 7 Jan 2014 10:14:25 +0800
> 
> > -static int phy_attach_direct(struct net_device *dev, struct
> > phy_device *phydev,
> > +int phy_attach_direct(struct net_device *dev, struct phy_device
> > +*phydev,
> >  			     u32 flags, phy_interface_t interface)
> 
> Since you are changing where the open parenthesis is, you must reindent
> the arguments on the second line so that they start exactly at the first
> column after that openning parenthesis.
> 
[S.H] OK. Thank you!
Will fix it in next version.

Best Regards, 
Shaohui Xie
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html