netdev - Re: [PATCH v3 net-next 1/3] sh_eth: Add support for r7s72100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140108000638.GB5136@verge.net.au>
Date:	Wed, 8 Jan 2014 09:06:39 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-sh@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, magnus.damm@...il.com,
	sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH v3 net-next 1/3] sh_eth: Add support for r7s72100

On Tue, Jan 07, 2014 at 02:07:55PM -0500, David Miller wrote:
> From: Simon Horman <horms+renesas@...ge.net.au>
> Date: Tue,  7 Jan 2014 11:27:13 +0900
> 
> > @@ -318,6 +371,14 @@ static int sh_eth_is_gether(struct sh_eth_private *mdp)
> >  		return 0;
> >  }
> >  
> > +static int sh_eth_is_rz_fast_ether(struct sh_eth_private *mdp)
> > +{
> > +	if (mdp->reg_offset == sh_eth_offset_fast_rz)
> > +		return 1;
> > +	else
> > +		return 0;
> > +}
> 
> Please make this return a boolean and use true/false.

Thanks. I will also refactor the giga_ether version of this
function accordingly.

> 
> > @@ -2061,6 +2155,10 @@ static struct net_device_stats *sh_eth_get_stats(struct net_device *ndev)
> >  {
> >  	struct sh_eth_private *mdp = netdev_priv(ndev);
> >  
> > +	if (sh_eth_is_rz_fast_ether(mdp)) {
> > +		return &ndev->stats;
> > +	}
> 
> Single statement basic blocks do not need curly braces, therefore
> please remove them here.

Will do.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html