netdev - Re: [PATCH net-next V2 1/3] net: Add GRO support for UDP encapsulating protocols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+mtBx8hnTtXD9ePSzcu2RGRghbmd4Wyu10HPmUu=gXcw5FaLA@mail.gmail.com>
Date:	Wed, 8 Jan 2014 08:29:45 -0800
From:	Tom Herbert <therbert@...gle.com>
To:	Or Gerlitz <ogerlitz@...lanox.com>
Cc:	Or Gerlitz <or.gerlitz@...il.com>, Jerry Chu <hkchu@...gle.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Linux Netdev List <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Yan Burman <yanb@...lanox.com>,
	Shlomo Pongratz <shlomop@...lanox.com>
Subject: Re: [PATCH net-next V2 1/3] net: Add GRO support for UDP
 encapsulating protocols

> Tom,
>
> OK, so I understand that you want the infrastructure to allow for direct udp
> encapsulation in the sense that there is no specific encapsulation header
> following the udp header.
>
> Take for example encapsulating TCP over UDP port X, the layer/driver that
> wants to enable gro for such traffic will register a udp gro handler for
> port X and in their gro receive/complete
> callbacks would just assume that following the UDP header there's TCP header
> and they will then issue a lookup in the inet gro handlers array to get the
> TCP gro handler, problem solved, agree?
>
Yes, that could work, but except for specifying a different protocol
number, the code to do direct encapsulation with GRO would be
identical for TCP/UDP, GRE/UDP, IPIP/UDP, ... we should be able to
avoid redundancy.  Let's get the basic UDP GRO support in, and then I
think adding support for direct encapsulation can be done without API
change in your proposed scheme.

> Or.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html