netdev - Re: [PATCH net] xen-netback: fix vif tx queue race in xenvif_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140108.151139.4522881609697040.davem@davemloft.net>
Date:	Wed, 08 Jan 2014 15:11:39 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	majieyue@...il.com
Cc:	netdev@...r.kernel.org, xen-devel@...ts.xen.org,
	jieyue.majy@...baba-inc.com, yingbin.wangyb@...baba-inc.com,
	tienan.ftn@...baba-inc.com, wei.liu2@...rix.com,
	ian.campbell@...rix.com, david.vrabel@...rix.com
Subject: Re: [PATCH net] xen-netback: fix vif tx queue race in
 xenvif_rx_interrupt

From: Ma JieYue <majieyue@...il.com>
Date: Thu,  9 Jan 2014 03:24:21 +0800

> -	if (xenvif_rx_schedulable(vif))
> +	if (netif_queue_stopped(vif->dev) && xenvif_rx_schedulable(vif))

I do not see anything which prevents a netif_stop_queue() call from happening
between these two tests in another thread of control.

This therefore looks like a bandaid and not a real fix.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html