netdev - RE: [PATCH net] bnx2x: fix DMA unmapping of TSO split BDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <504C9EFCA2D0054393414C9CB605C37F20E4C2B4@SJEXCHMB06.corp.ad.broadcom.com>
Date:	Thu, 9 Jan 2014 19:23:26 +0000
From:	Dmitry Kravkov <dmitry@...adcom.com>
To:	Eric Dumazet <eric.dumazet@...il.com>,
	Michal Schmidt <mschmidt@...hat.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Ariel Elior <ariele@...adcom.com>,
	Yuval Mintz <yuvalmin@...adcom.com>,
	David Miller <davem@...emloft.net>
Subject: RE: [PATCH net] bnx2x: fix DMA unmapping of TSO split BDs

> -----Original Message-----
> From: Eric Dumazet [mailto:eric.dumazet@...il.com]
> Sent: Thursday, January 09, 2014 7:52 PM
> To: Michal Schmidt
> Cc: netdev@...r.kernel.org; Ariel Elior; Yuval Mintz; Dmitry Kravkov; David
> Miller
> Subject: Re: [PATCH net] bnx2x: fix DMA unmapping of TSO split BDs
> 
> On Thu, 2014-01-09 at 14:36 +0100, Michal Schmidt wrote:
> > bnx2x triggers warnings with CONFIG_DMA_API_DEBUG=y:
> >
> >   WARNING: CPU: 0 PID: 2253 at lib/dma-debug.c:887
> check_unmap+0xf8/0x920()
> >   bnx2x 0000:28:00.0: DMA-API: device driver frees DMA memory with
> >   different size [device address=0x00000000da2b389e] [map size=1490
> bytes]
> >   [unmap size=66 bytes]
> >
> > The reason is that bnx2x splits a TSO BD into two BDs (headers + data)
> > using one DMA mapping for both, but it uses only the length of the
> > first BD when unmapping.
> >
> > This patch fixes the bug by unmapping the whole length of the two BDs.
> >
> > Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> > ---
> 
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> 

Thanks you, Guys.

Acked-by: Dmitry Kravkov <dmitry@...adcom.com>