lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Jan 2014 21:11:32 +0000 From: Ben Hutchings <bhutchings@...arflare.com> To: "Allan, Bruce W" <bruce.w.allan@...el.com> CC: Or Gerlitz <or.gerlitz@...il.com>, Bill Fink <billfink@...dspring.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH ethtool] ethtool: Accept long feature names reported by -k option as input to -K option On Wed, 2014-01-08 at 22:00 +0000, Allan, Bruce W wrote: > > -----Original Message----- > > From: netdev-owner@...r.kernel.org [mailto:netdev- > > owner@...r.kernel.org] On Behalf Of Ben Hutchings > > Sent: Wednesday, January 08, 2014 1:52 PM > > To: Or Gerlitz; Bill Fink; netdev@...r.kernel.org > > Subject: [PATCH ethtool] ethtool: Accept long feature names reported by -k > > option as input to -K option > > > > Before the generic features API was introduced, the ethtool -K option > > took short names for various features, e.g. 'gso' but the -k option > > reported their state using longer names, > > e.g. 'generic-segmentation-offload'. > > > > All newer features have a single kernel-provided name so input > > and output are consistent. But the old features still aren't, and > > although their short names are documented it's not good to have > > these exceptions. > > > > Change the argument parsing code for -K so that the long names > > reported by -k are also accepted. > > > > Reported-by: Or Gerlitz <or.gerlitz@...il.com> > > Signed-off-by: Ben Hutchings <bhutchings@...arflare.com> > > --- > > This turned out to be pretty easy to do as the argument processing is > > all table-driven already. I'll push this if it works for you. > > > > Ben. > > > > ethtool.c | 16 +++++++++++----- > > 1 file changed, 11 insertions(+), 5 deletions(-) > > Will there be an update to the man page, too? I wasn't intending to do so. The set of feature names is not known at compile time so I think it should only list the names that *aren't* reported by ethtool -K (the short names). Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists