netdev - Re: [PATCH net-next] net/mlx4_en: call gro handler for encapsulated frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1389308246.31367.70.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 09 Jan 2014 14:57:26 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Or Gerlitz <or.gerlitz@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, Amir Vadai <amirv@...lanox.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Jerry Chu <hkchu@...gle.com>
Subject: Re: [PATCH net-next] net/mlx4_en: call gro handler for encapsulated
 frames

On Fri, 2014-01-10 at 00:24 +0200, Or Gerlitz wrote:
> On Thu, Jan 9, 2014 at 8:30 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> > From: Eric Dumazet <edumazet@...gle.com>
> >
> > In order to use the native GRO handling of encapsulated protocols on
> > mlx4, we need to call napi_gro_receive() instead of netif_receive_skb()
> > unless busy polling is in action.
> >
> > While we are at it, rename mlx4_en_cq_ll_polling() to
> > mlx4_en_cq_busy_polling()
> >
> > Tested with GRE tunnel : GRO aggregation is now performed on the
> > ethernet device instead of being done later on gre device.
> 
> Hi Eric,
> 
> Just to make clear, this patch serves (very nicely!) encapsulated
> frames for which the HW is not able to do checksum check. For
> non-encapsulated packets or (e.g) vxlan encapsulated packets which are
> checksummed  by the HW we already go to the GRO path of the ethernet
> device.

Yes : mlx4 has two different paths, one calling napi_gro_frags(), and
one calling netif_receive_skb()

Obviously, the path calling napi_gro_frags() is already GRO enabled ;)

So if you are saying vxlan hits napi_gro_frags(), thats good to know,
but doesn't seem to be the case for GRE, IPIP, SIT tunnels.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html