netdev - Re: [PATCH net-next 3/3] xfrm: Don't prohibit AH from using ESN feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52CE8357.7030800@windriver.com>
Date:	Thu, 9 Jan 2014 19:09:11 +0800
From:	Fan Du <fan.du@...driver.com>
To:	Steffen Klassert <steffen.klassert@...unet.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 3/3] xfrm: Don't prohibit AH from using ESN feature



On 2014年01月09日 18:50, Steffen Klassert wrote:
> On Wed, Jan 08, 2014 at 04:53:12PM +0800, Fan Du wrote:
>> Clear checking when user try to use ESN through netlink keymgr for AH.
>>
>> Signed-off-by: Fan Du<fan.du@...driver.com>
>> ---
>>   net/xfrm/xfrm_user.c |    4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c
>> index 97681a3..f362a78 100644
>> --- a/net/xfrm/xfrm_user.c
>> +++ b/net/xfrm/xfrm_user.c
>> @@ -141,10 +141,6 @@ static inline int verify_replay(struct xfrm_usersa_info *p,
>>
>>   	if (!rt)
>>   		return 0;
>> -
>> -	if (p->id.proto != IPPROTO_ESP)
>> -		return -EINVAL;
>> -
>
> You can not change this as long as AH for ipv6 does not
> support ESN. Please provide the ipv6 side too.
>
> Also, simply removing this check is wrong in any case.
> You have to make sure that we catch if someone tries
> to insert an ESN state for other unsupported protocols,
> like ipcomp.
>

Sure, will add IPv6 support soon :)

-- 
浮沉随浪只记今朝笑

--fan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html