netdev - Re: [PATCH net-next 2/4] bonding: do not save non-existent device to bond primary in check params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140109114852.GH5786@redhat.com>
Date:	Thu, 9 Jan 2014 12:48:52 +0100
From:	Veaceslav Falico <vfalico@...hat.com>
To:	Ding Tianhong <dingtianhong@...wei.com>
Cc:	Jay Vosburgh <fubar@...ibm.com>,
	"David S. Miller" <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 2/4] bonding: do not save non-existent device to
 bond primary in check params

On Thu, Jan 09, 2014 at 07:20:39PM +0800, Ding Tianhong wrote:
>When install the bonding, the primay will be use to distinguish
>the primary slave for ab, alb and tlb mode, but it is meanless
>to save a no existed device, so add check for it.

Same remark as for the sysfs patch - we can have arbitrary name of the
interface in the paramter.

>
>Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>
>---
> drivers/net/bonding/bond_main.c | 20 +++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index de646e2..651c5fd 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -4246,13 +4246,19 @@ static int bond_check_params(struct bond_params *params)
> 		pr_debug("Warning: either miimon or arp_interval and arp_ip_target module parameters must be specified, otherwise bonding will not detect link failures! see bonding.txt for details.\n");
> 	}
>
>-	if (primary && !USES_PRIMARY(bond_mode)) {
>-		/* currently, using a primary only makes sense
>-		 * in active backup, TLB or ALB modes
>-		 */
>-		pr_warning("Warning: %s primary device specified but has no effect in %s mode\n",
>-			   primary, bond_mode_name(bond_mode));
>-		primary = NULL;
>+	if (primary) {
>+		if (!__dev_get_by_name(&init_net, primary)) {
>+			pr_warn("Warning: %s primary device is not exist\n",
>+				primary);
>+			primary = NULL;
>+		} else if (!USES_PRIMARY(bond_mode)) {
>+			/* currently, using a primary only makes sense
>+			 * in active backup, TLB or ALB modes
>+			 */
>+			pr_warn("Warning: %s primary device specified but has no effect in %s mode\n",
>+				primary, bond_mode_name(bond_mode));
>+			primary = NULL;
>+		}
> 	}
>
> 	if (primary && primary_reselect) {
>-- 
>1.8.0
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html