netdev - Re: [PATCH net-next] sctp: make sctp_addto_chunk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140110142919.GB10111@neilslaptop.think-freely.org>
Date:	Fri, 10 Jan 2014 09:29:19 -0500
From:	Neil Horman <nhorman@...driver.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Vlad Yasevich <vyasevich@...il.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] sctp: make sctp_addto_chunk_fixed local

On Thu, Jan 09, 2014 at 10:31:11PM -0800, Stephen Hemminger wrote:
> 
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
> 
> ---
>  include/net/sctp/structs.h |    1 -
>  net/sctp/sm_make_chunk.c   |    6 ++++--
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> --- a/include/net/sctp/structs.h	2014-01-09 22:29:51.871663405 -0800
> +++ b/include/net/sctp/structs.h	2014-01-09 22:29:58.323581984 -0800
> @@ -649,7 +649,6 @@ int sctp_user_addto_chunk(struct sctp_ch
>  			  struct iovec *data);
>  void sctp_chunk_free(struct sctp_chunk *);
>  void  *sctp_addto_chunk(struct sctp_chunk *, int len, const void *data);
> -void  *sctp_addto_chunk_fixed(struct sctp_chunk *, int len, const void *data);
>  struct sctp_chunk *sctp_chunkify(struct sk_buff *,
>  				 const struct sctp_association *,
>  				 struct sock *);
> --- a/net/sctp/sm_make_chunk.c	2014-01-09 22:29:51.871663405 -0800
> +++ b/net/sctp/sm_make_chunk.c	2014-01-09 22:29:58.323581984 -0800
> @@ -78,6 +78,8 @@ static int sctp_process_param(struct sct
>  			      gfp_t gfp);
>  static void *sctp_addto_param(struct sctp_chunk *chunk, int len,
>  			      const void *data);
> +static void  *sctp_addto_chunk_fixed(struct sctp_chunk *, int len,
> +				     const void *data);
>  
>  /* Control chunk destructor */
>  static void sctp_control_release_owner(struct sk_buff *skb)
> @@ -1475,8 +1477,8 @@ void *sctp_addto_chunk(struct sctp_chunk
>  /* Append bytes to the end of a chunk. Returns NULL if there isn't sufficient
>   * space in the chunk
>   */
> -void *sctp_addto_chunk_fixed(struct sctp_chunk *chunk,
> -			     int len, const void *data)
> +static void *sctp_addto_chunk_fixed(struct sctp_chunk *chunk,
> +				    int len, const void *data)
>  {
>  	if (skb_tailroom(chunk->skb) >= len)
>  		return sctp_addto_chunk(chunk, len, data);
> 
Acked-by: Neil Horman <nhorman@...driver.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html