netdev - Re: [PATCH net-next v2] ipv6: move IPV6_TCLASS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7Ob3Zhv=Oesh1cp53-0Eb-Cp2+dyduidT-KE0X3Tbqdmg@mail.gmail.com>
Date:	Fri, 10 Jan 2014 10:33:58 -0800
From:	Cong Wang <cwang@...pensource.com>
To:	roy.qing.li@...il.com
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2] ipv6: move IPV6_TCLASS_SHIFT into ipv6.h

On Fri, Jan 10, 2014 at 2:03 AM,  <roy.qing.li@...il.com> wrote:
> From: Li RongQing <roy.qing.li@...il.com>
>
> Two places defined IPV6_TCLASS_SHIFT, so we should move it into ipv6.h,
> and use this macro as possible.
>
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>
> ---
>  Sorry, version 1 has bug in fib6_rule_match it should be frist
> mask flowlabel with IPV6_TCLASS_MASK, then call ntohl


Since you are on it, it's better to introduce a helper function
for these 'shift and mask' operation.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html