netdev - Re: [RFC net-next 1/3] bonding: add infrastructure for an option API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A3A0930D-1C03-4C7E-91EE-A407FD3BF41F@cumulusnetworks.com>
Date:	Fri, 10 Jan 2014 11:29:30 -0800
From:	Scott Feldman <sfeldma@...ulusnetworks.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	Nikolay Aleksandrov <nikolay@...hat.com>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: [RFC net-next 1/3] bonding: add infrastructure for an option API

On Jan 10, 2014, at 11:19 AM, Stephen Hemminger <stephen@...workplumber.org> wrote:

> On Fri, 10 Jan 2014 14:11:33 +0100
> Nikolay Aleksandrov <nikolay@...hat.com> wrote:
> 
>> This patch adds the necessary basic infrastructure to support
>> centralized and unified option manipulation API for the bonding. The new
>> structure bond_option will be used to describe each option with its
>> dependencies on modes which will be checked automatically thus removing a
>> lot of duplicated code. Also automatic range checking is added for
>> non-string options. Currently the option setting function requires RTNL to
>> be acquired prior to calling it, since many options already rely on RTNL
>> it seemed like the best choice to protect all against common race
>> conditions.
> 
> Please add new features via netlink not sysfs.
> Sysfs is awkward API for command line, and not accessible through ip link.
> Also it provides no notification of changes or configuration back to switches
> and other things using netlink.

I don’t think Nikolay is adding a new bonding feature.  This patch series is a (very nice!) cleanup of option handling in the bonding driver.  The recently added netlink interface to bonding options is still intact.  This patch moves all the parsing/setting/getting/locking/bounds_checking/dependency_checking into one nice clean API.

I’m still reviewing patch set and might have more comments, but the first comment is: can this be generalized for more than just bonding?  It seems lots of drivers which maintain an option set could benefit from a similar API.

-scott--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html