lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Jan 2014 11:42:12 -0800 From: Tom Herbert <therbert@...gle.com> To: Eric Dumazet <eric.dumazet@...il.com> Cc: David Miller <davem@...emloft.net>, Linux Netdev List <netdev@...r.kernel.org> Subject: Re: [PATCH] net: Check skb->rxhash in gro_receive > Really, 99% of the time gro_list contains zero or one single slot, I > have hard data saying so. > Please provide the data. > If you want to optimize the case where list is fully populated (because > of yet another synthetic benchmark you use), you really need to build a > temporary list so that all layers do not even have to check > NAPI_GRO_CB(p)->same_flow > Well if you prefer, you can think of the "synthetic benchmark" as emulating an obvious DOS attack by pumping MSS sized TCP segments with random ports to a server. The stack needs to be resilient to such things, an O(n*m) algorithm in the data path is a red flag. > Each gro handler would remove non matching flow from this temp list. > > -> when we finally reach tcp_gro_receive(), list would contain a single > element. > > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists