netdev - Re: [PATCH 08/23] netfilter: nft_ct: load both IPv4 and IPv6 conntrack modules for NFPROTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140110.144813.659408334812475090.davem@davemloft.net>
Date:	Fri, 10 Jan 2014 14:48:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	sergei.shtylyov@...entembedded.com, pablo@...filter.org,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 08/23] netfilter: nft_ct: load both IPv4 and IPv6
 conntrack modules for NFPROTO_INET

From: Patrick McHardy <kaber@...sh.net>
Date: Fri, 10 Jan 2014 19:42:36 +0000

> I can see you're looking out for the important stuff. I consistently
> used this style in nftables so I'm not going to change it here.

Patrick, please follow the coding style conventions of the kernel,
these issues are important for long term sanity of the kernel tree.

It helps people who are looking at the netfilter code who perhaps
do not do so usually.  Do you really want to use a different style
and therefore make your code harder to read for them?  Really?

Your code being consistent with your code only is less important than
all of the networking looking the same.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html