netdev - Re: [PATCH v2 net-next] net: vxlan: when lower dev unregisters remove vxlan dev as well

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140110130118.1893fcc3@nehalam.linuxnetplumber.net>
Date:	Fri, 10 Jan 2014 13:01:18 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Daniel Borkmann <dborkman@...hat.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net: vxlan: when lower dev unregisters
 remove vxlan dev as well

On Fri, 10 Jan 2014 21:46:20 +0100
Daniel Borkmann <dborkman@...hat.com> wrote:

> +static int vxlan_lowerdev_event(struct notifier_block *unused,
> +				unsigned long event, void *ptr)
> +{
> +	struct net_device *dev = netdev_notifier_info_to_dev(ptr);
> +	struct vxlan_net *vn = net_generic(dev_net(dev), vxlan_net_id);
> +
> +	switch (event) {
> +	case NETDEV_UNREGISTER:
> +		/* Twiddle thumbs on netns device moves. */
> +		if (dev->reg_state != NETREG_UNREGISTERING)
> +			break;

No. Don't look at reg_state here. If moved from namespace
then it is a good as gone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html