netdev - Fw: [Bug 68501] New: llc_fixup_skb considers PDU len including ETH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140110151156.37ae2618@nehalam.linuxnetplumber.net>
Date:	Fri, 10 Jan 2014 15:11:56 -0800
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	netdev@...r.kernel.org
Subject: Fw: [Bug 68501] New: llc_fixup_skb considers PDU len including
 ETH_HLEN



Begin forwarded message:

Date: Fri, 10 Jan 2014 03:24:59 -0800
From: "bugzilla-daemon@...zilla.kernel.org" <bugzilla-daemon@...zilla.kernel.org>
To: "stephen@...workplumber.org" <stephen@...workplumber.org>
Subject: [Bug 68501] New: llc_fixup_skb considers PDU len including ETH_HLEN


https://bugzilla.kernel.org/show_bug.cgi?id=68501

            Bug ID: 68501
           Summary: llc_fixup_skb considers PDU len including ETH_HLEN
           Product: Networking
           Version: 2.5
    Kernel Version: 3.0.75
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: high
          Priority: P1
         Component: IPV4
          Assignee: shemminger@...ux-foundation.org
          Reporter: vkatabat@...il.com
        Regression: No

In below snip of code in llc_fixup_skb we calculate pdulen from
eth_hdr(skb)->h_proto which contains total length of packet include ETH_HLEN.

<snip>
119         if (skb->protocol == htons(ETH_P_802_2)) {
120                 __be16 pdulen = eth_hdr(skb)->h_proto;
121                 s32 data_size = ntohs(pdulen) - llc_len;
122 
123                 if (data_size < 0 ||
124                     !pskb_may_pull(skb, data_size))
125                         return 0;

</snip>


Line 121 should be changed to 

121                 s32 data_size = ntohs(pdulen) - llc_len - ETH_HLEN;



Log
---
kernel: pdu len 18432(72), data_size 69
kernel: skb len 55, skb data_len 0

-- 
You are receiving this mail because:
You are the assignee for the bug.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html