netdev - Re: [PATCH net-next] net: gro: change GRO overflow strategy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1389316137.31367.76.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 09 Jan 2014 17:08:57 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Cong Wang <cwang@...pensource.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Neal Cardwell <ncardwell@...gle.com>,
	Jerry Chu <hkchu@...gle.com>
Subject: Re: [PATCH net-next] net: gro: change GRO overflow strategy

On Thu, 2014-01-09 at 16:44 -0800, Cong Wang wrote:
> On Thu, Jan 9, 2014 at 2:12 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> > +               /* locate the end of the list to select the 'oldest' flow */
> > +               while (nskb->next) {
> > +                       pp = &nskb->next;
> > +                       nskb = *pp;
> > +               }
> > +               *pp = NULL;
> > +               nskb->next = NULL;
> 
> How long could this list be?
> 

#define MAX_GRO_SKBS 8

> I think it's time to use doubly linked list for gro,
> although definitely not in this patch.

Its not needed, and it would be slower.

In fast path, we do not need to get the previous pointers.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html