netdev - [PATCH v2 0/3] atheros: modify statistics code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1389549040-8785-1-git-send-email-sd@queasysnail.net>
Date:	Sun, 12 Jan 2014 18:50:37 +0100
From:	Sabrina Dubroca <sd@...asysnail.net>
To:	davem@...emloft.net
Cc:	netdev@...r.kernel.org, bhutchings@...arflare.com,
	jcliburn@...il.com, chris.snook@...il.com,
	Sabrina Dubroca <sd@...asysnail.net>
Subject: [PATCH v2 0/3] atheros: modify statistics code

Following Ben Hutchings's advice on how to fill net_stats in alx [1],
this patch modifies the other atheros ethernet drivers
similarly. Minor whitespace/empty line changes in atl1c and atl1e to
make the code completely consistent between atl1c, atl1e, and alx.

I don't have this hardware, so these patches have only been
compile-tested.


v2 (changes only in atl1):
 - don't set soft_stats.rx_missed_errors (Ben)
 - add errors to soft_stats.{rx,tx}_packets (Ben)
 - add soft_stats.rx_dropped field and update soft_stats.rx_dropped
   instead of netdev->stats (overwritten) outside of the stats
   update function

Detail of the changes (v1):
* atl1/atl1c/atl1e
  - fix collisions computation
  - rx_dropped = rx_rrd_ov
  - rx_over_errors = 0
  - rx_missed_errors = 0
  - X_packets = X_ok + X_errors

* only atl1c/atl1e
  - add rx_rxf_ov to rx_errors


[1] http://www.spinics.net/lists/netdev/msg264930.html


Sabrina Dubroca (3):
  atl1c: update statistics code
  atl1e: update statistics code
  atl1:  update statistics code

 drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 31 +++++++++++-------
 drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 30 ++++++++++-------
 drivers/net/ethernet/atheros/atlx/atl1.c        | 43 ++++++++++++++-----------
 drivers/net/ethernet/atheros/atlx/atl1.h        |  1 +
 4 files changed, 65 insertions(+), 40 deletions(-)

-- 
1.8.5.2

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html