netdev - Re: [PATCH net-next] qlcnic: Convert vmalloc/memset to kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Jan 2014 11:17:50 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	jitendra.kalsaria@...gic.com, linux-driver@...gic.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] qlcnic: Convert vmalloc/memset to kcalloc

From: Joe Perches <joe@...ches.com>
Date: Wed, 08 Jan 2014 22:42:25 -0800

> vmalloc is a limited resource.  Don't use it unnecessarily.
> 
> It seems this allocation should work with kcalloc.
> 
> Remove unnecessary memset(,0,) of buf as it's completely
> overwritten as the previously only unset field in
> struct qlcnic_pci_func_cfg is now set to 0.
> 
> Use kfree instead of vfree.
> Use ETH_ALEN instead of 6.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Applied, thanks Joe.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html