netdev - Re: [patch net-next] neigh: use NEIGH_VAR_INIT in ndo_neigh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140113.113538.1561843824076418241.davem@davemloft.net>
Date:	Mon, 13 Jan 2014 11:35:38 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jiri@...nulli.us
Cc:	netdev@...r.kernel.org, jes@...ined-monkey.org
Subject: Re: [patch net-next] neigh: use NEIGH_VAR_INIT in ndo_neigh_setup
 functions.

From: Jiri Pirko <jiri@...nulli.us>
Date: Thu,  9 Jan 2014 14:13:47 +0100

> When ndo_neigh_setup is called, the bitfield used by NEIGH_VAR_SET is
> not initialized yet. This might cause confusion for the people who use
> NEIGH_VAR_SET in ndo_neigh_setup. So rather introduce NEIGH_VAR_INIT for
> usage in ndo_neigh_setup.
> 
> Signed-off-by: Jiri Pirko <jiri@...nulli.us>

Wouldn't it be better to move the neigh_parms_data_state_cleanall() call
before we invoke ->ndo_neigh_setup()?  It seems that this code intended
to work that way, no?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html